Thread (7 messages) 7 messages, 2 authors, 2016-06-27

Re: [PATCH v2] cryptodev: uninline parameter parsing

From: Thomas Monjalon <hidden>
Date: 2016-06-26 16:32:00

2016-06-25 15:24, De Lara Guarch, Pablo:
quoted
+DPDK_16.07 {
+	global:
+
+	rte_cryptodev_parse_vdev_init_params;
I think this function does not need to be public.
This function is only called in the PMDs, and the only public function
to initialize a crypto device is rte_eal_vdev_init.
It needs to be public to be called by the PMDs,
like, example, rte_cryptodev_pmd_virtual_dev_init.
Also, could you remove the includes of rte_vargs.h in the PMDs,
as it is not needed (I think it was not necessary before either).
Yes I am going to send a v3 with this change.
Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help