Re: [PATCH v4 1/5] pdump: fix default socket path
From: Pattan, Reshma <hidden>
Date: 2016-06-24 15:05:55
From: Pattan, Reshma <hidden>
Date: 2016-06-24 15:05:55
-----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] Sent: Friday, June 24, 2016 3:55 PM To: Pattan, Reshma <redacted> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 1/5] pdump: fix default socket path 2016-06-24 14:54, Reshma Pattan:quoted
+#define SOCKET_DIR "/pdump_sockets"I think the default socket directory should contain dpdk as prefix. Like dpdk-pdump-sockets (I think dash is preferred for filenames). I wonder whether it should be a hidden directory: ~/.dpdk-pdump-sockets And after all, why not simply ~/.dpdk/
Hmm I would keep the name dpdk-pdump-sockets as library creates this only for pdump sockets. Hidden directory just gives the advantage of not cluttering the display. If your comment is for the same I can add a . in the directory name:-).
It would allow other DPDK applications to put some files.