Re: [PATCH] doc: virtio pmd versions
From: Wang, Zhihong <hidden>
Date: 2016-06-15 06:59:50
-----Original Message----- From: Mcnamara, John Sent: Thursday, June 9, 2016 8:56 PM To: Richardson, Bruce <redacted>; Wang, Zhihong [off-list ref]; dev@dpdk.org Cc: Wang, Zhihong <redacted> Subject: RE: [dpdk-dev] [PATCH] doc: virtio pmd versionsquoted
-----Original Message----- From: Richardson, Bruce Sent: Thursday, June 9, 2016 1:53 PM To: Mcnamara, John <redacted>; Wang, Zhihong [off-list ref]; dev@dpdk.org Cc: Wang, Zhihong <redacted> Subject: RE: [dpdk-dev] [PATCH] doc: virtio pmd versionsquoted
-----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John<snip>quoted
quoted
-----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhihong Wang<snip>quoted
quoted
+ +Virtio PMD Versions +------------------- + +Virtio driver has 3 versions of rx functions and 2 versions of tx functions.In some places RX/TX is used and in some rx/tx. I would suggest the uppercase versions throughout.In the commit logs, the only valid contractions allowed by the check-git- log.sh script are Rx and Tx bad=$(echo "$headlines" | grep -E --color=always \ -e '\<(rx|tx|RX|TX)\>' \ .... I would therefore suggest we follow the same rules for the docs for consistency.Hi, I don't mind what it is once we have consistency, so Rx/Tx is fine. Zhihong, please note.
Thank you John and Bruce! V2 has been sent, please take a look.
John