Re: [PATCH] mk: fix missing DEPDIRS to avoid libarary underlinking
From: Thomas Monjalon <hidden>
Date: 2016-06-13 10:08:06
2016-06-13 11:48, Christian Ehrhardt:
quoted hunk ↗ jump to hunk
--- a/drivers/net/af_packet/Makefile +++ b/drivers/net/af_packet/Makefile@@ -54,5 +54,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += rte_eth_af_packet.c DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_mbuf DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_ether DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_kvargs +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_eal
It looks more logical to have eal as first DEPDIR in these lists.
quoted hunk ↗ jump to hunk
--- a/drivers/net/vhost/Makefile +++ b/drivers/net/vhost/Makefile@@ -36,6 +36,8 @@ include $(RTE_SDK)/mk/rte.vars.mk # LIB = librte_pmd_vhost.a +LDLIBS += -lpthread +
It is not a DEPDIR but an external dependency. It deserves a separate patch. Do we need it in rte.app.mk? It is an EAL dependency as well.