Re: [PATCH v2 08/40] bnxt: add completion ring support
From: Bruce Richardson <hidden>
Date: 2016-05-26 09:38:03
On Fri, May 13, 2016 at 03:45:57PM -0700, Stephen Hurd wrote:
quoted hunk ↗ jump to hunk
Structures, macros, and functions for working with completion rings in the driver. Signed-off-by: Stephen Hurd <redacted> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h | 6 + drivers/net/bnxt/bnxt_cpr.c | 139 +++++++++++++++++++ drivers/net/bnxt/bnxt_cpr.h | 88 ++++++++++++ drivers/net/bnxt/bnxt_hwrm.c | 18 +++ drivers/net/bnxt/bnxt_hwrm.h | 2 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 239 ++++++++++++++++++++++++++++++++- 7 files changed, 487 insertions(+), 6 deletions(-) create mode 100644 drivers/net/bnxt/bnxt_cpr.c create mode 100644 drivers/net/bnxt/bnxt_cpr.hdiff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile index 757ea62..afd1690 100644 --- a/drivers/net/bnxt/Makefile +++ b/drivers/net/bnxt/Makefile@@ -48,6 +48,7 @@ EXPORT_MAP := rte_pmd_bnxt_version.map # # all source are stored in SRCS-y # +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_cpr.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_ethdev.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_hwrm.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_ring.cdiff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 846972e..4e0b514 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h@@ -42,6 +42,9 @@ #include <rte_lcore.h> #include <rte_spinlock.h> +/* TODO make bnxt.def_cp_ring a pointer to avoid this... */ +#include "bnxt_cpr.h" +
I see this TODO is fixed a couple of patches later. Can we get the fix included in this patch so that the TODO never appears? /Bruce