Thread (71 messages) 71 messages, 6 authors, 2016-06-20

Re: [RFC PATCH v2 1/3] rte: change xstats to use integer keys

From: Remy Horton <hidden>
Date: 2016-05-18 08:45:38

On 18/05/2016 09:31, Tahhan, Maryam wrote:
[..]
quoted
+	eth_xstats_count_t         xstats_count;
+	/**< Get number of extended statistics. */
Hi Remy
While reviewing the second patch in this patchset I noticed you aren't actually using
eth_xstats_count_t   xstats_count in the eth_dev_ops to retrieve the count in the driver.
Do you still need xstats_count?
Well spotted - bit of dead code that slipped through the net when I 
decided to use the existing convention for the driver-side interface.

Currently working on a v3 that will convert all the drivers, so will fix 
in that patchset.

..Remy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help