Thread (4 messages) 4 messages, 4 authors, 2016-03-31

Re: [PATCH] nfp: copy pci info from pci to ethdev

From: Alejandro Lucero <hidden>
Date: 2016-03-29 07:16:50

Hi guys,

Sorry for the delay but I was on a Easter break.

That patch is OK for me. In fact, I had one patch ready for upstreaming
with this change needed for supporting hotplug. I was waiting for some
feedback from one internal project needing this hotplug functionality
before submitting.

Regards


On Fri, Mar 25, 2016 at 12:31 PM, Bruce Richardson <
bruce.richardson@intel.com> wrote:
On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote:
quoted
The NFP driver (unlike other PCI devices) was not copying the pci info
from the pci_dev to the eth_dev.  This would make the driver_name be
null (and other unset fields) when application uses dev_info_get.

This was found by code review; do not have the hardware.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
Alejandro,

any review or ack on this patch for nfp driver?

Regards,
/Bruce
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help