Re: [PATCH v2] ixgbe: add check for tx queue number

-----Original Message-----
From: Fischetti, Antonio
Sent: Thursday, March 24, 2016 8:40 AM
To: De Lara Guarch, Pablo; dev@dpdk.org
Cc: Lu, Wenzhuo; De Lara Guarch, Pablo
Subject: RE: [dpdk-dev] [PATCH v2] ixgbe: add check for tx queue number

quoted

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
Sent: Wednesday, March 23, 2016 3:29 PM
To: dev@dpdk.org
Cc: Lu, Wenzhuo <redacted>; De Lara Guarch, Pablo
[off-list ref]
Subject: [dpdk-dev] [PATCH v2] ixgbe: add check for tx queue number

IXGBE supports 128 TX queues. However, the full 128 queues
are only available in VT and DCB mode.
In normal default "none" mode (VT/DCB off) the maximum number
of available queues is only 64.
IXGBE doesn't check the mode when reporting the available
number of queues. If a queue larger than 64 is used in default mode,
the TX packets will be dropped silently.

This change adds a check to forbid using a queue number larger than 64
during device configuration (in default mode), so that the problem is
reported as early as possible.
It also changes the order of where the dev_conf parameters are copied
into the dev structure so that the correct maximum number of queues
is reported for the correct mode.

Signed-off-by: Wenzhuo Lu <redacted>
Signed-off-by: Pablo de Lara <redacted>

Tested-by: Antonio Fischetti <redacted>

Self-NACK. Will include release notes update and split the patch.