Thread (5 messages) 5 messages, 3 authors, 2016-03-17

Re: [PATCH] eal_interrupts.c: properly init struct epoll_event (valgrind)

flat view

From: Matthew Hall <hidden>
Date: 2016-03-17 23:00:56

On Thu, Mar 17, 2016 at 10:19:24AM -0700, Stephen Hemminger wrote:
quoted
quoted
A better patch would be to move the data structure into the
code block used, and get rid of the useless else (rte_panic never returns);
and fix the indentation, and use C99 initialization which should make valgrind
happier.

The moral is don't just slap memsets around
Hi guys,

As you probably read before, I am a security developer, not a low-level / 
kernel guy, and my DPDK work is spare time only. So I try to limit the scope 
of my DPDK patches where possible, to avoid making headaches for the full-time 
team to the minimum required. I can try to redo or refactor all this unrelated 
stuff in the code, but I wouldn't be as fast or accurate as you would.

Matthew.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help