Re: [PATCH 6/8] drivers/net/e1000/igb: Signed left shift operator
From: Panu Matilainen <hidden>
Date: 2016-03-10 13:29:49
On 02/25/2016 08:48 PM, Aaron Conole wrote:
quoted hunk ↗ jump to hunk
Tell the compiler to use an unsigned constant for the config shifts. Signed-off-by: Aaron Conole <aconole@redhat.com> --- drivers/net/e1000/igb_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index 1d00dda..afe80f5 100644 --- a/drivers/net/e1000/igb_pf.c +++ b/drivers/net/e1000/igb_pf.c@@ -172,8 +172,8 @@ int igb_pf_host_configure(struct rte_eth_dev *eth_dev) E1000_WRITE_REG(hw, E1000_VT_CTL, vtctl); /* Enable pools reserved to PF only */ - E1000_WRITE_REG(hw, E1000_VFRE, (~0) << vf_num); - E1000_WRITE_REG(hw, E1000_VFTE, (~0) << vf_num); + E1000_WRITE_REG(hw, E1000_VFRE, (~0U) << vf_num); + E1000_WRITE_REG(hw, E1000_VFTE, (~0U) << vf_num); /* PFDMA Tx General Switch Control Enables VMDQ loopback */ if (hw->mac.type == e1000_i350)
Acked-by: Panu Matilainen <redacted> CC'd the e1000 maintainer too. - Panu -