Re: [PATCH v2 1/2] lpm: extend ip4 next_hop and add config structure
From: Kobylinski, MichalX <hidden>
Date: 2016-03-02 16:23:32
-----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] Sent: Wednesday, March 2, 2016 4:29 PM To: Kobylinski, MichalX <redacted> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add config structure Importance: High Hi,
Hi Thomas, thank you for suggested.
As suggested by Bruce, I'm looking to apply this patchset before the ARM one. Please check the comments below. Is it possible to split the changes in next_hop and config structure?
It is possible. Do you mean to put config structure into seperate patch-set?
quoted
--- a/doc/guides/rel_notes/release_2_3.rst +++ b/doc/guides/rel_notes/release_2_3.rst@@ -18,7 +18,11 @@ Drivers Libraries ~~~~~~~~~ +** librte_lpm: Increase number of next hops for IPv4 to 2^24 ** +Extend next_hop field from 8-bits to 24-bits for IPv4. Changed structures: +rte_lpm_tbl24_entry and rte_lpm_tbl8_entry to one structurerte_lpm_tbl_entry.quoted
+Added a new rte_lpm_config structure.The spacing is wrong here. Please check also the past tense. There is a template in the release notes.quoted
+BIND_DEFAULT_SYMBOL(rte_lpm_add, _v23, 2.3); MAP_STATIC_SYMBOL( + int rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth, + uint32_t next_hop), rte_lpm_add_v23);The version will be 16.04 instead of 2.3.