Re: [PATCH] i40e: remove redundant compiler warning disablers
From: Pei, Yulong <hidden>
Date: 2016-02-29 05:51:27
This patch caused build error with i686-native-linuxapp-gcc (gcc version is 4.8.3)
quoted
i686-native-linuxapp-gcc compile error info: INSTALL-LIB librte_pmd_vmxnet3_uio.a /root/dpdk/drivers/net/i40e/base/i40e_common.c: In function âi40e_aq_set_lldp_mibâ: /root/dpdk/drivers/net/i40e/base/i40e_common.c:3772:32: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] cmd->address_high = CPU_TO_LE32(I40E_HI_WORD((u64)buff)); ^ /root/dpdk/drivers/net/i40e/base/i40e_common.c:3773:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] cmd->address_low = CPU_TO_LE32(I40E_LO_DWORD((u64)buff)); ^ /root/dpdk/drivers/net/i40e/base/i40e_common.c: In function âi40e_aq_set_arp_proxy_configâ: /root/dpdk/drivers/net/i40e/base/i40e_common.c:5817:33: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] cmd->address_high = CPU_TO_LE32(I40E_HI_DWORD((u64)proxy_config)); ^ /root/dpdk/drivers/net/i40e/base/i40e_common.c:5818:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] cmd->address_low = CPU_TO_LE32(I40E_LO_DWORD((u64)proxy_config)); ^ /root/dpdk/drivers/net/i40e/base/i40e_common.c: In function âi40e_aq_set_ns_proxy_table_entryâ: /root/dpdk/drivers/net/i40e/base/i40e_common.c:5852:14: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] CPU_TO_LE32(I40E_HI_DWORD((u64)ns_proxy_table_entry)); ^ /root/dpdk/drivers/net/i40e/base/i40e_common.c:5854:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] CPU_TO_LE32(I40E_LO_DWORD((u64)ns_proxy_table_entry)); ^ /root/dpdk/drivers/net/i40e/base/i40e_common.c: In function âi40e_aq_set_clear_wol_filterâ: /root/dpdk/drivers/net/i40e/base/i40e_common.c:5914:33: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] cmd->address_high = CPU_TO_LE32(I40E_HI_DWORD((u64)filter)); ^ /root/dpdk/drivers/net/i40e/base/i40e_common.c:5915:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] cmd->address_low = CPU_TO_LE32(I40E_LO_DWORD((u64)filter)); ^ cc1: all warnings being treated as errors make[6]: *** [i40e_common.o] Error 1 make[5]: *** [i40e] Error 2 make[5]: *** Waiting for unfinished jobs.... INSTALL-LIB librte_pmd_ixgbe.a AR librte_pmd_e1000.a INSTALL-LIB librte_pmd_e1000.a make[4]: *** [net] Error 2 make[3]: *** [drivers] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2
-----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen Sent: Monday, December 7, 2015 8:37 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] i40e: remove redundant compiler warning disablers These may have been required at some point but current i40e base driver compiles cleanly without them, at least with clang 3.7.0 and gcc 5.1.1. Signed-off-by: Panu Matilainen <redacted> --- drivers/net/i40e/Makefile | 13 ------------- 1 file changed, 13 deletions(-)
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile index 033ee4a..4ffaf0d 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile@@ -53,23 +53,10 @@ CFLAGS_BASE_DRIVER = -wd593 -wd188 else ifeq ($(CC), clang) CFLAGS_BASE_DRIVER += -Wno-sign-compare CFLAGS_BASE_DRIVER += -Wno-unused-value -CFLAGS_BASE_DRIVER += -Wno-unused-parameter -CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -CFLAGS_BASE_DRIVER += -Wno-format -CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers -CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast -CFLAGS_BASE_DRIVER += -Wno-format-nonliteral CFLAGS_BASE_DRIVER += -Wno-unused-variable else CFLAGS_BASE_DRIVER = -Wno-sign-compare CFLAGS_BASE_DRIVER += -Wno-unused-value -CFLAGS_BASE_DRIVER += -Wno-unused-parameter -CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -CFLAGS_BASE_DRIVER += -Wno-format -CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers -CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast -CFLAGS_BASE_DRIVER += -Wno-format-nonliteral -CFLAGS_BASE_DRIVER += -Wno-format-security CFLAGS_BASE_DRIVER += -Wno-unused-variable ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) --
2.5.0