Thread (16 messages) 16 messages, 5 authors, 2016-02-26

Re: [PATCH v2] ixgbe: Fix disable interrupt twice

From: Bruce Richardson <hidden>
Date: 2016-02-26 14:39:15

On Tue, Feb 23, 2016 at 02:10:57AM +0000, Zhang, Helin wrote:
quoted
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
Sent: Friday, January 29, 2016 1:58 PM
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice

Currently, ixgbe vf and pf will disable interrupt twice in stop stage and uninit
stage. It will cause an error:

    testpmd> quit

    Shutting down port 0...
    Stopping ports...
    Done
    Closing ports...
    EAL: Error disabling MSI-X interrupts for fd 26
    Done

Becasue the interrupt already been disabled in stop stage.
Since it is enabled in init stage, better remove from stop stage.

Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF")

Signed-off-by: Michael Qiu <redacted>
Acked-by: Helin Zhang <redacted>
applied to dpdk-next-net/rel_16_04

/Bruce
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help