Thread (63 messages) 63 messages, 10 authors, 2016-12-21

Re: [PATCH] eal: make resource initialization more robust

From: Neil Horman <nhorman@tuxdriver.com>
Date: 2016-02-22 13:18:48

On Mon, Feb 22, 2016 at 02:08:51PM +0800, Tan, Jianfeng wrote:
Hi Neil,

Sorry that for my previous misconfiguration of email agent, I missed this
email.
quoted
This looks alot better.  One minor comment, the sigbus handler, you should
probably store the previous bus handler and restore it after you map all
the
hugepages you want (lest you overwrite something an application is doing
with
sigbus).
I did not catch your point. I did store it "static struct sigaction
action_old" and recover it after mapping all the hugepages. Can you give
more details on this?
Nope, I can't because I missed the fact you had done that.  Apologies, it looks
good.

Acked-by: Neil Horman <nhorman@tuxdriver.com>
Thanks,
Jianfeng
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help