Re: [PATCH 1/3] i40e: enable DCB in VMDQ vsis
From: Bruce Richardson <hidden>
Date: 2016-02-12 12:16:40
On Wed, Jan 20, 2016 at 04:57:14PM +0800, Jingjing Wu wrote:
Previously, DCB is only enabled on PF, queue mapping and BW configuration is only done on PF vsi. This patch enabled DCB for VMDQ vsis by following steps: 1. Take BW and ETS configuration on VEB. 2. Take BW and ETS configuration on VMDQ vsis. 3. Update TC and queues mapping on VMDQ vsis. To enable DCB on VMDQ, the number of TCs should not be lager than
typo: s/lager/larger/
the number of queues in VMDQ pools, and the number of queues per VMDQ pool is specified by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM in config/common_* file. Signed-off-by: Jingjing Wu <redacted>
In the title and commit log, can you please capitalize the abbreviation VSI, so that VSIs is recognisable as a plural of the acronym, and not as the word "vsis", which confused me for a while. :-) Can you also explain what ETS stands for. [Not sure if VSI also needs to be expanded out the first time it is used in the message]
quoted hunk ↗ jump to hunk
--- doc/guides/rel_notes/release_2_3.rst | 2 + drivers/net/i40e/i40e_ethdev.c | 153 ++++++++++++++++++++++++++++++----- drivers/net/i40e/i40e_ethdev.h | 28 ++++--- 3 files changed, 151 insertions(+), 32 deletions(-)diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst index 99de186..cd3d391 100644 --- a/doc/guides/rel_notes/release_2_3.rst +++ b/doc/guides/rel_notes/release_2_3.rst@@ -4,6 +4,8 @@ DPDK Release 2.3 New Features ------------ +* **Added i40e DCB support in VMDQ mode.**
Suggest to reword this as: "Added support for DCB in VMDQ mode to i40e driver"
quoted hunk ↗ jump to hunk
+ Resolved Issues ---------------diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index bf6220d..fbafcc6 100644
<snip> Thanks, /Bruce