Re: [PATCH v6 1/2] tools: Add support for handling built-in kernel modules

W dniu 28.01.2016 o 12:22, Panu Matilainen pisze:

On 01/28/2016 01:17 PM, Kamil Rytarowski wrote:

quoted

I retained the logic for special case of vfio-pci. At the moment
(according to my knowledge) there are no other DPDK modules with this
name replacement.

I checked few example Linux modules and if a module is named with dash,
it's being replaced to underscore. The modprobe(8) tool can accept both
names as interchangeable (with dash and underscore).

Would you like to make it a general rule and replace all dashes with
underscores?

It would be nice to behave the same as modprobe wrt dash and 
underscore, yes.

    - Panu -

My patch is intended to support built-in modules, the rest isn't that 
trivial without changing the behavior.

I prototyped it and it added extra unnecessary complexity, while we just 
want to handle vfio_pci -> vfio-pci.

I'm going to submit new version with improved comment in the code. 
Please continue possible improvements in separate threads.