Re: [PATCH v5] vfio: Support for no-IOMMU mode
From: Thomas Monjalon <hidden>
Date: 2016-01-27 17:08:16
2016-01-27 16:50, Anatoly Burakov:
quoted hunk ↗ jump to hunk
--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +int vfio_type1_dma_map(int); +int vfio_noiommu_dma_map(int);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files I agree with checkpatch, they should be static ;)
quoted hunk ↗ jump to hunk
--- a/lib/librte_eal/linuxapp/eal/eal_vfio.h +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h +/* older kernels may not have no-IOMMU mode */ +#ifndef VFIO_NOIOMMU_IOMMU +#define VFIO_NOIOMMU_IOMMU 8 +#endif
Shouldn't it be defined privately in .c file?