Re: [dpdk-dev, 2/2] ethdev: move code to common place in hotplug

Hello,

On Thu, Jan 21, 2016 at 7:42 PM, Thomas Monjalon
[off-list ref] wrote:

2016-01-21 19:06, David Marchand:

quoted

On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin [off-list ref] wrote:

quoted

This change modifies the return value from -EINVAL to -1. I don't know
whether is this an issue but it looks suspicious.

Should not be an issue, as the api does not give details on expected
negative return values.
Just noticed, this also introduces a new log message that was not
displayed before.

To be safe, I suppose I should restore this.

Thomas, opinion ?

I'm OK with the log message added for this error case.
I would just keep the -EINVAL return value.

Ok will do.


-- 
David Marchand