Re: [PATCH v5 7/9] eal: pci: export pci_[un]map_device
From: David Marchand <hidden>
Date: 2016-01-19 08:18:01
From: David Marchand <hidden>
Date: 2016-01-19 08:18:01
On Tue, Jan 19, 2016 at 9:12 AM, Yuanhan Liu [off-list ref] wrote:
Normally we could set RTE_PCI_DRV_NEED_MAPPING flag so that eal will invoke pci_map_device internally for us. From that point view, there is no need to export pci_map_device. However, for virtio pmd driver, which is designed to work without binding UIO (or something similar first), pci_map_device() will fail, which ends up with virtio pmd driver being skipped. Therefore, we can not set RTE_PCI_DRV_NEED_MAPPING blindly at virtio pmd driver. Therefore, this patch exports pci_map_device, and let virtio pmd call it when necessary. Cc: David Marchand <redacted> Signed-off-by: Yuanhan Liu <redacted> Tested-By: Santosh Shukla <redacted> Tested-by: Qian Xu <redacted> Reviewed-by: Tetsuya Mukawa <redacted> Tested-by: Tetsuya Mukawa <redacted>
lgtm Acked-by: David Marchand <redacted> -- David Marchand