Re: [PATCH v4 07/14] virtio: vfio: add api support to rd/wr ioport bar

On Fri, Jan 15, 2016 at 11:33 AM, Yuanhan Liu
[off-list ref] wrote:

On Thu, Jan 14, 2016 at 06:58:30PM +0530, Santosh Shukla wrote:

quoted

For vfio case - Use pread/pwrite api to access virtio
ioport space.

Signed-off-by: Santosh Shukla <redacted>
Signed-off-by: Rizwan Ansari <redacted>
Signed-off-by: Rakesh Krishnamurthy <redacted>
---

...

quoted

+/* vfio rd/rw virtio apis */
+static inline void ioport_inb(const struct rte_pci_device *pci_dev,
+                           uint8_t reg, uint8_t *val)

Minor nit: dpdk perfers to seperate return type and function name in
different line:

  static inline void
  ioport_inb(....)
  {

ok.

quoted

+{
+     if (rte_eal_pci_read_bar(pci_dev, (uint8_t *)val, sizeof(uint8_t), reg,

                                          ^^^^^^^^^^^

Unnecessary cast; and few more belows.

yes,

        --yliu