Re: [PATCH v2] app/testpmd Fix max_socket detection
From: Stephen Hurd <hidden>
Date: 2016-01-15 00:59:39
Yes, this is cause a bug which prevents cross-socket testing... per michael.qiu@intel.com on Fri 12/18/2015 5:33 PM (unable to find email on the list)
quoted
Hi, Stephen I just see this patch and found some issue with it. When I start testpmd with -c 0x3 but with socket-num 1, that means run lcore in socket 0, but want hugepage allocated in socket 1, in previous, it works, I don't know why you force it in the socket lcore locates.I would like to give a warning instead of failure. just like before: EAL: Requesting 512 pages of size 2MB from socket 1 EAL: TSC frequency is ~2294689 KHz EAL: WARNING: Master core has no memory on local socket! After your patch: EAL: No probed ethernet devices Interactive-mode selected EAL: Error - exiting with code: 1 Cause: The socket number should be < 1
His example command was: ./testpmd -c 0x3 -n 4 -- -i -socket-num=1 -- Stephen Hurd -----Original Message----- From: Bruce Richardson [mailto:bruce.richardson@intel.com] Sent: Thursday, January 14, 2016 5:44 AM To: Stephen Hurd Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection On Wed, Jan 13, 2016 at 02:23:36PM -0800, Stephen Hurd wrote:
Previously, max_socket was set to the highest numbered socket with an enabled lcore. The intent is to set it to the highest socket regardless of it being enabled.
Can you clarify why this changes is necessary? Is it causing a bug somewhere? thanks, /Bruce