Thread (8 messages) 8 messages, 4 authors, 2016-03-03

Re: [PATCH] mk: fix examples build failure

From: steeven lee <hidden>
Date: 2016-01-05 10:20:51

Hi Michael:

Seems the examples makefile seems to be broken, easy to reproduce on
master branch, below is the outputs on Ubuntu 14.04 amd64 version:

~/work/dpdk$ export RTE_SDK=/home/steeven/work/dpdk
~/work/dpdk$ cd /home/steeven/work/dpdk/examples/helloworld/
~/work/dpdk/examples/helloworld$ export RTE_TARGET=x86_64-native-linuxapp-gcc
~/work/dpdk/examples/helloworld$ make
/home/steeven/work/dpdk/mk/internal/rte.extvars.mk:57: *** Cannot find
.config in /home/xueming/work/dpdk.  Stop.
~/work/dpdk/examples/helloworld$ cd ../cmdline/
~/work/dpdk/examples/cmdline$ make
/home/steeven/work/dpdk/mk/internal/rte.extvars.mk:57: *** Cannot find
.config in /home/xueming/work/dpdk.  Stop.


Thanks,
Steeven

On Mon, Dec 28, 2015 at 12:20 PM, Qiu, Michael [off-list ref] wrote:
On 12/24/2015 8:38 PM, steeven lee wrote:
quoted
1. Fix examples build failure
2. make build as default output folder name

Signed-off-by: steeven <redacted>
---
 mk/internal/rte.extvars.mk | 4 ++--
 mk/rte.extsubdir.mk        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 040d39f..cabef0a 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -52,9 +52,9 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
 export RTE_EXTMK

 # RTE_SDK_BIN must point to .config, include/ and lib/.
-RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
+RTE_SDK_BIN := $(RTE_SDK)/build
 ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
-$(error Cannot find .config in $(RTE_SDK))
+$(error Cannot find .config in $(RTE_SDK_BIN))
 endif

 #
diff --git a/mk/rte.extsubdir.mk b/mk/rte.extsubdir.mk
index f50f006..819020a 100644
--- a/mk/rte.extsubdir.mk
+++ b/mk/rte.extsubdir.mk
@@ -46,7 +46,7 @@ $(DIRS-y):
        @echo "== $@"
        $(Q)$(MAKE) -C $(@) \
                M=$(CURDIR)/$(@)/Makefile \
-               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
+               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
                BASE_OUTPUT=$(BASE_OUTPUT) \
                CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
                S=$(CURDIR)/$(@) \
Could you show your compile error log? And how to reproduce it?

Thanks,
Michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help