[PATCH 17/28] fm10k: store actual count of DWORDS pulled/pushed from mbmem
flat view
STALE4026d
From: Wang Xiao W <hidden>
Date: 2015-09-10 04:39:25
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
A previous bug was uncovered by addition of a debug stat to indicate the actual number of DWORDS we pulled from the mbmem. It turned out this was not the same as the tx_dwords counter. While the previous bug fix should have corrected this in all cases, add some debug stats that count the number of DWORDs pushed or pulled from the mbmem. Base drivers can use this in debug builds to help detect this problem in the future. Signed-off-by: Wang Xiao W <redacted> --- drivers/net/fm10k/base/fm10k_mbx.c | 4 ++++ drivers/net/fm10k/base/fm10k_mbx.h | 2 ++ 2 files changed, 6 insertions(+)
diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_mbx.c
index ad9d81a..c6d34eb 100644
--- a/drivers/net/fm10k/base/fm10k_mbx.c
+++ b/drivers/net/fm10k/base/fm10k_mbx.c@@ -394,6 +394,8 @@ STATIC void fm10k_mbx_write_copy(struct fm10k_hw *hw, if (!tail) tail++; + mbx->tx_mbmem_pulled++; + /* write message to hardware FIFO */ FM10K_WRITE_MBX(hw, mbmem + tail++, *(head++)); } while (--len && --end);
@@ -480,6 +482,8 @@ STATIC void fm10k_mbx_read_copy(struct fm10k_hw *hw, if (!head) head++; + mbx->rx_mbmem_pushed++; + /* read message from hardware FIFO */ *(tail++) = FM10K_READ_MBX(hw, mbmem + head++); } while (--len && --end);
diff --git a/drivers/net/fm10k/base/fm10k_mbx.h b/drivers/net/fm10k/base/fm10k_mbx.h
index 6332584..4b22f0e 100644
--- a/drivers/net/fm10k/base/fm10k_mbx.h
+++ b/drivers/net/fm10k/base/fm10k_mbx.h@@ -313,8 +313,10 @@ struct fm10k_mbx_info { u64 tx_dropped; u64 tx_messages; u64 tx_dwords; + u64 tx_mbmem_pulled; u64 rx_messages; u64 rx_dwords; + u64 rx_mbmem_pushed; u64 rx_parse_err; /* Buffer to store messages */
--
1.9.3