Re: [PATCH] qos_meter: Fix compilation with APP_MODE_FWD
From: Thomas Monjalon <hidden>
Date: 2015-08-25 13:44:07
From: Thomas Monjalon <hidden>
Date: 2015-08-25 13:44:07
2015-08-25 13:34, Mcnamara, John:
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalonquoted
This patch should not be accepted to discourage build-time options. Patch for run-time option is welcome.The patch is fixing a compilation issue, which seems reasonable. It isn't introducing a build time option, it is merely fixing an typo in an existing one.
Yes
Yes, it would be better not to have this build time option (in which case the issue would have been found sooner) but that isn't the responsibility of the person submitting this patch.
Yes
That is something that should be pushed back to the author/maintainer.
Yes
In the meantime this patch is still valid and should be applied.
No After trying to request this kind of cleanup for several months, nothing happens. Maybe it will be more efficient to leave bugs until someone submit a real cleanup.