Thread (1 message) 1 message, 1 author, 2015-07-09

Re: [PATCH 1/4] eal: provide functions to access PCI config

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2015-07-09 21:08:24

On Wed, 17 Jun 2015 14:44:31 +0000
David Marchand [off-list ref] wrote:
+       if (len == 3 || len > sizeof(pi.pi_data)) {
+               RTE_LOG(ERR, EAL, "%s(): invalid pci read length\n", __func__);
+               goto error;
+       }

A comment on length 3 would help to understand why it is refused.

PCI only supports 1, 2, and 4 byte transactions.
Hopefully someone using this would understand that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help