Re: [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD
From: Bruce Richardson <hidden>
Date: 2015-06-30 15:40:21
On Tue, Jun 30, 2015 at 04:08:08PM +0100, Iremonger, Bernard wrote:
quoted
-----Original Message----- From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] Sent: Tuesday, June 30, 2015 9:27 AM To: dev@dpdk.org Cc: Iremonger, Bernard; david.marchand@6wind.com; Richardson, Bruce; Tetsuya.Mukawa Subject: [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD From: "Tetsuya.Mukawa" <redacted> This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables it as default in both Linux and BSD. Also, to support port hotplug, rte_eal_pci_scan() and below missing symbols should be exported to ethdev library. - rte_eal_parse_devargs_str() - rte_eal_pci_close_one() - rte_eal_pci_probe_one() - rte_eal_pci_scan() - rte_eal_vdev_init() - rte_eal_vdev_uninit() Signed-off-by: Tetsuya Mukawa <redacted>Hi Tetsuya, Would it be cleaner to add this patch to the [PATCH v7 12/12] patch set as patch 13 rather than having it as a separate patch?
The other patch set is cleanup, merging BSD and Linuxapp code, so I think it's best kept as a separate set. New features I'd suggest keeping separate from cleanup. That being said, it is only one patch, so it probably doesn't matter much either way. :-) /Bruce