-----Original Message-----
From: Olivier MATZ [mailto:olivier.matz@6wind.com]
Sent: Monday, June 1, 2015 4:50 PM
To: Zhang, Helin; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/5] ixgbe: remove a discarded source line

Hi Helin,

On 05/26/2015 10:36 AM, Helin Zhang wrote:

quoted

Little endian to CPU order conversion had been added for reading vlan
tag from RX descriptor, while its original source line was forgotten
to delete. That's a discarded source line and should be deleted.

Signed-off-by: Helin Zhang <redacted>
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c

b/drivers/net/ixgbe/ixgbe_rxtx.c index 4f9ab22..041c544 100644

--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c

@@ -981,7 +981,6 @@ ixgbe_rx_scan_hw_ring(struct ixgbe_rx_queue *rxq)
 			pkt_len = (uint16_t)(rxdp[j].wb.upper.length - rxq->crc_len);
 			mb->data_len = pkt_len;
 			mb->pkt_len = pkt_len;
-			mb->vlan_tci = rxdp[j].wb.upper.vlan;
 			mb->vlan_tci = rte_le_to_cpu_16(rxdp[j].wb.upper.vlan);

 			/* convert descriptor fields to rte mbuf flags */

Maybe the following should be added in the commit log:
Fixes: 23fcffe8ffac ("ixgbe: fix id and hash with flow director")

Agree, will add it. Thanks!
- Helin

Acked-by: Olivier Matz <redacted>