Re: [PATCH v9 09/12] ixgbe: enable rx queue interrupts for both PF and VF
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2015-05-29 15:57:15
On Fri, 29 May 2015 16:45:22 +0800 Cunming Liang [off-list ref] wrote:
+ if (intr_handle->intr_vec == NULL) {
+ PMD_INIT_LOG(ERR, "Failed to allocate %d rx_queues"
+ "intr_vec\n", dev->data->nb_rx_queues);
+ return -1;
+ }
+Please return an actual error code (like -ENOMEM) rather than generic -1. It allows for easier diagnosis when using API's.