Thread (1 message) 1 message, 1 author, 2015-01-30

Re: [PATCH] mk: allow application to override clean

From: Thomas Monjalon <hidden>
Date: 2015-01-30 10:46:07

2015-01-29 22:36, Stephen Hemminger:
On Thu, 29 Jan 2015 02:52:45 -0800
Thomas Monjalon [off-list ref] wrote:
quoted
Hi Stephen,

2015-01-28 12:00, Olivier MATZ:
quoted
Hi Stephen,

On 01/23/2015 07:19 AM, stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org wrote:
quoted
From: Stephen Hemminger <redacted>

In some cases application may want to have additional rules
for clean. This can be handled by allowing the double colon
form of rule.

  https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html
There is already a way to do that in dpdk makefiles: you can add
the following code in your application Makefile, before the line
that includes $(RTE_SDK)/mk/rte.app.mk:

POSTCLEAN += my_clean

.PHONY: my_clean
my_clean:
	@echo executed after clean
Does it fit with your needs?
Should we revert your patch? Double-colon rules were avoided in DPDK.
"Double-colon rules are somewhat obscure and not often very useful"
Works for me.
So the commit is now reverted:
	http://dpdk.org/browse/dpdk/commit/?id=785e1a0932b67136

-- 
Thomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help