Thread (1 message) 1 message, 1 author, 2015-01-16

Re: [PATCH] ethdev: fix missing parenthesis

From: Thomas Monjalon <hidden>
Date: 2015-01-16 17:04:12

2015-01-16 09:40, Wodkowski, PawelX:
quoted
Good catch!
Was introduced in commit 4bdefaade6d1 (VMDQ enhancements).
Note that quite often, when a patch contains too much things,
we miss this kind of bugs. That's a reason to well split patches.
What is most surprising I did not spotted this, neither  the compiler
what I think it should. It was my IDE which pointed possible bug.

Are we using '-Wparentheses' switch? If not, we should consider
to use this switch?
It's already included in -Wall which is set in WERROR_FLAGS.

-- 
Thomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help