Re: ret_pktmbuf_pool_init problem with opaque_arg

Hi Alejandro,

On 01/09/2015 03:12 PM, Alejandro Lucero wrote:

Inside this function mbuf_data_room_size is set to a default value if
opaque_arg is null and it should be set to the value pointed by opaque_arg
if not null. Current implementation is using not the value but with the
pointer itself. I think this:

        roomsz = (uint16_t)(uintptr_t)opaque_arg;

should be something like this:

        roomsz = *(uint16_t *)opaque_arg;

In this particular case, the integer value is stored in the pointer
value: the pointer is not used as a pointer but as an integer. I agree
it can be surprising, but I think the code is correct.

Regards,
Olivier