Re: [PATCH v2 1/4] compat: Add infrastructure to support symbol versioning

On Tue, Dec 23, 2014 at 01:27:32PM +0000, Gonzalez Monroy, Sergio wrote:

quoted

From: Neil Horman [mailto:nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org]
Sent: Monday, December 22, 2014 8:24 PM

+++ b/lib/librte_compat/Makefile

[...]
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+
+# install includes
+SYMLINK-y-include := rte_compat.h
+
+include $(RTE_SDK)/mk/rte.lib.mk

I just realized that we can avoid doing the _INSTALL change below if we include
mk/rte_install.mk instead of mk/rte_lib.mk, as it is done in librte_net.

Regards,
Sergio

But doing so limits the compat directory to only install headers, correct? I'm
ok with that mind you, just need to keep it in mind if we ever add any sort of
compatibility code there.

Neil

quoted

diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 81bf8e1..cbd439b 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk

@@ -40,10 +40,17 @@ VPATH += $(SRCDIR)

[...]
+
 _BUILD = $(LIB)
-_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y)
$(RTE_OUTPUT)/lib/$(LIB)
+_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) ifneq ($(LIB),)
+_INSTALL += $(RTE_OUTPUT)/lib/$(LIB) endif
 _CLEAN = doclean

 .PHONY: all
--
1.9.3