[PATCH] dmaengine: mmp_pdma: Handle error for dma_set_mask
From: Jiasheng Jiang <hidden>
Date: 2022-03-02 10:02:48
Also in:
lkml
Subsystem:
dma generic offload engine subsystem, the rest · Maintainers:
Vinod Koul, Linus Torvalds
As the potential failure of the dma_set_mask(),
it should be better to check it and return error
if fails.
Fixes: c8acd6aa6bed ("dmaengine: mmp-pdma support")
Signed-off-by: Jiasheng Jiang <redacted>
---
drivers/dma/mmp_pdma.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
index 5a53d7fcef01..12085d9fae95 100644
--- a/drivers/dma/mmp_pdma.c
+++ b/drivers/dma/mmp_pdma.c@@ -1101,9 +1101,11 @@ static int mmp_pdma_probe(struct platform_device *op) pdev->device.residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR; if (pdev->dev->coherent_dma_mask) - dma_set_mask(pdev->dev, pdev->dev->coherent_dma_mask); + ret = dma_set_mask(pdev->dev, pdev->dev->coherent_dma_mask); else - dma_set_mask(pdev->dev, DMA_BIT_MASK(64)); + ret = dma_set_mask(pdev->dev, DMA_BIT_MASK(64)); + if (ret) + return ret; ret = dma_async_device_register(&pdev->device); if (ret) {
--
2.25.1