Hi Wen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Wen-He/dmaengine-fsl-qdma-add-NXP-Layerscape-qDMA-engine-driver-support/20171225-232227
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   In file included from drivers//dma/fsl-qdma.c:27:0:
   drivers//dma/fsldma.h: In function 'in_be64':
   drivers//dma/fsldma.h:202:15: error: implicit declaration of function 'in_be32'; did you mean 'in_be64'? [-Werror=implicit-function-declaration]
     return ((u64)in_be32((u32 __iomem *)addr) << 32) |
                  ^~~~~~~
                  in_be64
   drivers//dma/fsldma.h: In function 'out_be64':
   drivers//dma/fsldma.h:208:2: error: implicit declaration of function 'out_be32'; did you mean 'out_be64'? [-Werror=implicit-function-declaration]
     out_be32((u32 __iomem *)addr, val >> 32);
     ^~~~~~~~
     out_be64
   drivers//dma/fsldma.h: In function 'in_le64':
   drivers//dma/fsldma.h:215:15: error: implicit declaration of function 'in_le32'; did you mean 'in_le64'? [-Werror=implicit-function-declaration]
     return ((u64)in_le32((u32 __iomem *)addr + 1) << 32) |
                  ^~~~~~~
                  in_le64
   drivers//dma/fsldma.h: In function 'out_le64':
   drivers//dma/fsldma.h:221:2: error: implicit declaration of function 'out_le32'; did you mean 'out_le64'? [-Werror=implicit-function-declaration]
     out_le32((u32 __iomem *)addr + 1, val >> 32);
     ^~~~~~~~
     out_le64
   drivers//dma/fsl-qdma.c: In function 'qdma_readl':

quoted

drivers//dma/fsl-qdma.c:275:9: error: implicit declaration of function 'FSL_DMA_IN'; did you mean 'FSL_DMA_EOL'? [-Werror=implicit-function-declaration]

     return FSL_DMA_IN(qdma, addr, 32);
            ^~~~~~~~~~
            FSL_DMA_EOL
   drivers//dma/fsl-qdma.c: In function 'qdma_writel':
   drivers//dma/fsl-qdma.c:281:2: error: implicit declaration of function 'FSL_DMA_OUT'; did you mean 'FSL_DMA_EOL'? [-Werror=implicit-function-declaration]
     FSL_DMA_OUT(qdma, addr, val, 32);
     ^~~~~~~~~~~
     FSL_DMA_EOL
   In file included from drivers//dma/fsl-qdma.c:27:0:
   At top level:
   drivers//dma/fsldma.h:219:13: warning: 'out_le64' defined but not used [-Wunused-function]
    static void out_le64(u64 __iomem *addr, u64 val)
                ^~~~~~~~
   drivers//dma/fsldma.h:213:12: warning: 'in_le64' defined but not used [-Wunused-function]
    static u64 in_le64(const u64 __iomem *addr)
               ^~~~~~~
   drivers//dma/fsldma.h:206:13: warning: 'out_be64' defined but not used [-Wunused-function]
    static void out_be64(u64 __iomem *addr, u64 val)
                ^~~~~~~~
   drivers//dma/fsldma.h:200:12: warning: 'in_be64' defined but not used [-Wunused-function]
    static u64 in_be64(const u64 __iomem *addr)
               ^~~~~~~
   cc1: some warnings being treated as errors

vim +275 drivers//dma/fsl-qdma.c

   272	
   273	static u32 qdma_readl(struct fsl_qdma_engine *qdma, void __iomem *addr)
   274	{
 > 275		return FSL_DMA_IN(qdma, addr, 32);
   276	}
   277
---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation