quoted

quoted

Ensure child node references are decremented properly in the error path.

…

quoted

+++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c

@@ -279,8 +279,10 @@ static int s32_dt_node_to_map(struct pinctrl_dev *pctldev,
 		ret = s32_dt_group_node_to_map(pctldev, np, map,
 					       &reserved_maps, num_maps,
 					       np_config->name);
-		if (ret < 0)
+		if (ret < 0) {
+			of_node_put(np);
 			break;
+		}
 	}

 	if (ret)

May the same error predicate be applied at two places here?

I think these two error predicates can be combined together in another patch.

Are you going to reduce such error predicates so that exception handling
can be improved another bit?

Regards,
Markus