Re: [PATCH 5.10.y-cip 15/21] can: rcar_canfd: Add support for RZ/G2L family
From: Pavel Machek <hidden>
Date: 2021-12-23 18:43:21
Attachments
- signature.asc [application/pgp-signature] 195 bytes
From: Pavel Machek <hidden>
Date: 2021-12-23 18:43:21
Hi!
quoted
quoted
+ if (gpriv->chip_id == RENESAS_RZG2L) { + char *irq_name; + int err_irq; + int tx_irq; + + err_irq = platform_get_irq_byname(pdev, ch == 0 ? "ch0_err" : "ch1_err"); + if (err_irq < 0) { + err = err_irq; + goto fail; + }This leaks ndev; it should free_candev(ndev); before returning, AFAICT.Agreed, this needs a fix.
Yes. OTOH this is just a problem in error paths. Other patches look good, so this should probably be fixed in the mainline. I can apply the series if there are no other comments. Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany