Hi!

On Thu, Sep 30, 2021 at 3:56 AM Pavel Machek [off-list ref] wrote:

AFAICT we are reviewing changes to those drivers on -stable series
(good). We are not testing the drivers in any meaningful way, and it
may be good to mark them built-in (=y, not modular) in some configs so
at least probing is tested. Proper testing would be quite hard, and
ammount of changes to them in stable probably does not require it.

I think functional testing for wireless drivers in CI system is hard,
so building and
probing seem reasonable tests currently.

* wl18xx

(wl1837 hardware is handled by wl18xx driver.)

CONFIG_WL18XX
CONFIG_BT_HCIUART_LL
./drivers/net/wireless/ti/wl18xx
./drivers/bluetooth/hci_ll.c

./5.10.y-cip/arm64/qemu_arm64_defconfig:CONFIG_WL18XX=m
./5.10.y-cip/arm64/ctj_zynqmp_defconfig:CONFIG_WL18XX=y
./5.10.y-cip/arm/moxa_mxc_defconfig:CONFIG_WL18XX=m

./5.10.y-cip/arm64/qemu_arm64_defconfig:CONFIG_BT_HCIUART_LL=y
./5.10.y-cip/arm64/ctj_zynqmp_defconfig:CONFIG_BT_HCIUART_LL=y

=> We should be reviewing it. We do some minimal testing by compiling
module in ZYNQMP configuration. No changes in 5.10-stable. Very few
changes from 4.19, mostly treewide cleanups.

zynqmp-zcu102 which is connected to CIP LAVA doesn't have the wl18xx
device actually.
On the other hand, RZ/G2 boards (r8a774a1-hihope-rzg2m-ex,
r8a774b1-hihope-rzg2n-ex,
r8a774c0-ek874) have the device. So these boards look suitable if
probing is tested, although
wl18xx is currently not enabled in the corresponding config files.

Best regards,
Hiraku Toyooka
Cybertrust Japan Co., Ltd.