Re: [cip-dev] [PATCH v3 4.19.y-cip 08/17] spi: spi-mem: export spi_mem_default_supports_op()
From: "Sudip Mukherjee" <sudip.mukherjee@codethink.co.uk>
Date: 2021-01-05 17:47:23
On 05/01/2021 16:51, Pavel Machek wrote:
Hi!quoted
From: Naga Sureshkumar Relli <redacted>quoted
This patch also squashes upstream commit 72e6841608b9 ("spi: spi-mem: Fix build error without CONFIG_SPI_MEM")' in the current patch as commit 46109648052f ("spi: spi-mem: export spi_mem_default_supports_op()")' introduced below build error when built without CONFIG_SPI_MEM:This puts function definition directly into header file; I don't think that will work when multiple files include it. Adding "static inline" is the usual solution for this.
Has been done upstream by b5881b153bc8 ("spi: spi-mem: Make
spi_mem_default_supports_op() static inline")
I was once raising this concern internally that when commits are
backported not all of them are backported but since I did not know
enough about how CIP wants to do the backporting so never raised the
issue. But this is an example what I was concerned about.
--
Regards
Sudip