Thread (99 messages) 99 messages, 3 authors, 2018-07-10

[cip-dev] [PATCH 62/86] ARM: dts: r8a7745: Add operating-points to cpu0

From: Ben Hutchings <hidden>
Date: 2018-07-10 17:12:15

On Mon, 2018-07-09 at 10:29 +0000, Fabrizio Castro wrote:
Hello Ben,

Thank you for your feedback!
quoted
-----Original Message-----
From: Ben Hutchings [mailto:ben.hutchings at codethink.co.uk]
Sent: 08 July 2018 20:02
To: Fabrizio Castro <redacted>
Cc: cip-dev at lists.cip-project.org; Chris Paterson <redacted>; Biju Das <redacted>
Subject: Re: [cip-dev][PATCH 62/86] ARM: dts: r8a7745: Add
operating-points to cpu0

On Fri, 2018-07-06 at 10:00 +0000, Fabrizio Castro wrote:
quoted
Hello Ben,

Thank you for your feedback.
quoted
Subject: Re: [cip-dev][PATCH 62/86] ARM: dts: r8a7745: Add
operating-points to cpu0

On Fri, 2018-06-29 at 15:39 +0100, Fabrizio Castro wrote:
quoted
shmobile_defconfig builds cpu freq into the kernel by default,
therefore we get error and warning messages at boot, when
hotplugging cpus, and when waking up from suspend to RAM.

Although the r8a7745 SoC does not support DVFS, defining one
operating point makes cpu freq happy and therefore all of the
nasty messages disappear.
Why was this not needed upstream?
Since there is a chance for the OPP to be registered dynamically the
upstream kernel won't print error messages (only debug messages), as
opposed to the CIP kernel which will print error messages. Have a
look at 5b60697cd89cf5a438b2984e11859228e5ec1c6b.
[...]

Then I will cherry-pick that commit instead.
Could you please cherry-pick this commit too then:
035ed07208dc501d023873447113f3f178592156 ("PM / OPP: Move error
message to debug level")
OK, done.

Ben.

-- 
Ben Hutchings, Software Developer                ?        Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help