Re: [PATCH v2 21/33] net: support ns lookup
From: Jan Kara <jack@suse.cz>
Date: 2025-09-15 12:02:56
Also in:
linux-block, linux-fsdevel, linux-kselftest, linux-nfs, lkml, netdev
On Fri 12-09-25 13:52:44, Christian Brauner wrote:
Support the generic ns lookup infrastructure to support file handles for namespaces. The network namespace has a separate list with different lifetime rules which we can just leave in tact. We have a similar concept for mount namespaces as well where it is on two differenet lists for different purposes. Signed-off-by: Christian Brauner <brauner@kernel.org>
Just some nits below. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz>
quoted hunk ↗ jump to hunk
diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 025a7574b275..42075748dff1 100644 --- a/include/net/net_namespace.h +++ b/include/net/net_namespace.h@@ -11,6 +11,7 @@ #include <linux/list.h> #include <linux/sysctl.h> #include <linux/uidgid.h> +#include <linux/nstree.h> #include <net/flow.h> #include <net/netns/core.h>
Why this include?
quoted hunk ↗ jump to hunk
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 5fb7bd8ac45a..169ec22c4758 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c@@ -20,6 +20,7 @@ #include <linux/sched/task.h> #include <linux/uidgid.h> #include <linux/proc_fs.h> +#include <linux/nstree.h> #include <net/aligned_data.h> #include <net/sock.h>@@ -445,7 +446,7 @@ static __net_init int setup_net(struct net *net) LIST_HEAD(net_exit_list); int error = 0; - net->net_cookie = atomic64_inc_return(&net_aligned_data.net_cookie); + net->net_cookie = ns_tree_gen_id(&net->ns);
net_cookie seems to be unused now and can be deleted? Honza -- Jan Kara [off-list ref] SUSE Labs, CR