Thread (16 messages) 16 messages, 2 authors, 2023-10-25

Re: [PATCH-cgroup 1/4] workqueue: Add workqueue_unbound_exclude_cpumask() to exclude CPUs from wq_unbound_cpumask

From: Tejun Heo <tj@kernel.org>
Date: 2023-10-24 03:28:59
Also in: linux-doc, linux-kselftest, lkml

Hello,

On Wed, Oct 18, 2023 at 03:18:52PM -0400, Waiman Long wrote:
I have a second thought after taking a further look at that. First of all,
cpuset_allowed_mask isn't relevant here and the mask can certainly contain
offline CPUs. So cpu_possible_mask is the proper fallback.

With the current patch, wq_user_unbound_cpumask is set up initially as 
(HK_TYPE_WQ ∩ HK_TYPE_DOMAIN) house keeping mask and rewritten by any
subsequent write to workqueue/cpumask sysfs file. So using
The current behavior is not something which is carefully planned. It's more
accidental than anything. If we can come up with a more intutive and
consistent behavior, that should be fine.
wq_user_unbound_cpumask has the implied precedence of user-sysfs written
mask, command line isolcpus or nohz_full option mask and cpu_possible_mask.
I think just fall back to wq_user_unbound_cpumask if the operation fails
should be enough.
But yeah, that sounds acceptable.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help