Re: [PATCH v3] mm/memcontrol: use kstrtobool for swapaccount param parsing
From: Michal Hocko <mhocko@suse.com>
Date: 2022-09-19 15:01:24
Also in:
linux-doc, linux-mm, lkml
On Tue 13-09-22 15:13:58, Liu Shixin wrote:
Use kstrtobool which is more powerful to handle all kinds of parameters like 'Yy1Nn0' or [oO][NnFf] for "on" and "off".
the main usefulness is with the code reusability of library functions rather than ad-hoc stuff.
Signed-off-by: Liu Shixin <redacted>
Acked-by: Michal Hocko <mhocko@suse.com> Thanks!
quoted hunk ↗ jump to hunk
--- mm/memcontrol.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 0a1a8a846870..5511c0c120d9 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c@@ -7434,10 +7434,10 @@ bool mem_cgroup_swap_full(struct folio *folio) static int __init setup_swap_account(char *s) { - if (!strcmp(s, "1")) - cgroup_memory_noswap = false; - else if (!strcmp(s, "0")) - cgroup_memory_noswap = true; + bool res; + + if (!kstrtobool(s, &res)) + cgroup_memory_noswap = !res; return 1; } __setup("swapaccount=", setup_swap_account);-- 2.25.1
-- Michal Hocko SUSE Labs