Re: [PATCH memcg 2/3] memcg: remove charge forcinig for dying tasks
From: Michal Hocko <hidden>
Date: 2021-10-21 10:03:28
Also in:
linux-mm, lkml
On Thu 21-10-21 00:20:02, Tetsuo Handa wrote:
On 2021/10/20 23:57, Michal Hocko wrote:quoted
One argument for removing it from here is the maintainability. Now you have a memcg specific check which is not in sync with the oom. E.g. out_of_memory does task_will_free_mem as the very first thing. You are also automatically excluding oom killer for cases where that might make a sense.What makes it possible to remove this check? This check was added because task_will_free_mem() in out_of_memory() does NOT work. See commit 7775face207922ea ("memcg: killed threads should not invoke memcg OOM killer").
You are right. I've forgot about this and should have checked git blame. Thanks for bringing this up! -- Michal Hocko SUSE Labs