Thread (3 messages) 3 messages, 3 authors, 2021-09-27

Re: [PATCH] cgroup/debug: Fix lockdep splat with "%pK" format specifier

From: Tejun Heo <hidden>
Date: 2021-09-27 16:43:41
Also in: lkml

Hello,

On Sun, Sep 26, 2021 at 10:58:07PM -0400, Waiman Long wrote:
The lockdep splat is caused by the fact that the debug controller use the
"%pK" format specifier to print out address of cset's with css_set_lock
held. Under some circumstances, the use of "%pK" format specifier may
acquire the selinux_ss.policy_rwlock.

To avoid this possible deadlock scenario, we have to abandon the use of
the "%pK" format specifier and just use "%p" to always hash the cset
addresses. The actual cset addresses aren't that important as long as
they are unique for matching purpose.
Isn't the right thing to do here making the selinux rwlock an irqsafe one?
It's a bit crazy to have printf specifier to have restrictive locking
requirements.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help