Thread (7 messages) 7 messages, 4 authors, 2021-09-14

Re: [PATCH] ipc: remove memcg accounting for sops objects in do_semtimedop()

From: Michal Hocko <mhocko@suse.com>
Date: 2021-09-14 14:32:25
Also in: lkml

On Tue 14-09-21 16:23:16, Michal Koutny wrote:
On Tue, Sep 14, 2021 at 09:13:48AM +0200, Michal Hocko [off-list ref] wrote:
quoted
"
This object can consume up to 2 pages, syscall is sleeping one,
size and duration can be controlled by user, and this allocation
can be repeated by many thread at the same time.
"

It sounds like a problem, except it is not because? A worst case
scenario evaluation would be beneficial for example
AFAICS, the offending allocation is in place only during the duration of
the syscall. So it's basically O(#tasks).
Considering at least 2 pages for task_struct + 2 pages for kernel stack,
back of the envelope calculation gives me the footprint amplification is
<1.5.
The factor would IMO be interesting if it was >> 2 (from the PoV of
excessive (ab)use, fine-grained accounting seems to be currently
unfeasible due to performance impact).
Yes this sounds exactly like something I would appreciate in the
changelog. With that or similar feel free to add
Acked-by: Michal Hocko <mhocko@suse.com>

Thanks a lot Michal for this clarification! 
The commit message can be more explicit about this but to the patch
Reviewed-by: Michal Koutný <mkoutny@suse.com>
-- 
Michal Hocko
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help