Re: [PATCH] misc_cgroup: use a counter to count the number of failures
From: Tejun Heo <hidden>
Date: 2021-08-13 16:16:50
Also in:
lkml
From: Tejun Heo <hidden>
Date: 2021-08-13 16:16:50
Also in:
lkml
Hello, On Fri, Aug 13, 2021 at 01:26:11PM +0800, brookxu wrote:
From: Chunguang Xu <redacted> For a container, we only print an error log when the resource charge fails. There may be some problems here: 1. If a large number of containers are created and deleted, there will be a lot of error logs. 2. According to an error log, we cannot better understand the actual pressure of resources. Therefore, perhaps we should use a failcnt counter to count the number of failures, so that we can easily understand the actual pressure of resources and avoid too many error log.. This is a partial patch of the previous serial, which may be useful, so I resend it.
I think this approach is fine but can you please * Cc the original author of the misc cgroup who added the warning messages. * Rename failcnt to nr_fails? Thanks. -- tejun