Re: [PATCH v3 10/18] mm/memcg: Convert mem_cgroup_uncharge() to take a folio
From: Christoph Hellwig <hidden>
Date: 2021-07-01 07:18:43
Also in:
linux-mm
From: Christoph Hellwig <hidden>
Date: 2021-07-01 07:18:43
Also in:
linux-mm
On Wed, Jun 30, 2021 at 05:00:26AM +0100, Matthew Wilcox (Oracle) wrote:
Convert all the callers to call page_folio(). Signed-off-by: Matthew Wilcox (Oracle) <redacted> --- include/linux/memcontrol.h | 4 ++-- mm/filemap.c | 2 +- mm/khugepaged.c | 4 ++-- mm/memcontrol.c | 14 +++++++------- mm/memory-failure.c | 2 +- mm/memremap.c | 2 +- mm/page_alloc.c | 2 +- mm/swap.c | 2 +- 8 files changed, 16 insertions(+), 16 deletions(-)diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 90d48b0e3191..d6386a2b9d7a 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h@@ -710,7 +710,7 @@ int mem_cgroup_swapin_charge_page(struct page *page, struct mm_struct *mm, gfp_t gfp, swp_entry_t entry); void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry); -void mem_cgroup_uncharge(struct page *page); +void mem_cgroup_uncharge(struct folio *);
why do you drop the parameter name? Otherwise looks good: Reviewed-by: Christoph Hellwig <redacted>