Thread (9 messages) 9 messages, 3 authors, 2021-07-26

Re: [PATCH v5 02/16] memcg: enable accounting for IP address and routing-related objects

From: Shakeel Butt <hidden>
Date: 2021-07-19 14:23:17
Also in: lkml, netdev

On Mon, Jul 19, 2021 at 7:00 AM Dmitry Safonov [off-list ref] wrote:
Hi Vasily,

On Mon, 19 Jul 2021 at 11:45, Vasily Averin [off-list ref] wrote:
[..]
quoted
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index ae1f5d0..1bbf239 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -968,7 +968,7 @@ static __always_inline bool memcg_kmem_bypass(void)
                return false;

        /* Memcg to charge can't be determined. */
-       if (in_interrupt() || !current->mm || (current->flags & PF_KTHREAD))
+       if (!in_task() || !current->mm || (current->flags & PF_KTHREAD))
                return true;
This seems to do two separate things in one patch.
Probably, it's better to separate them.
(I may miss how route changes are related to more generic
__alloc_pages() change)
It was requested to squash them together in some previous versions.
https://lore.kernel.org/linux-mm/YEiUIf0old+AZssa-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help