Re: [GIT PULL] cgroup changes for v5.14-rc1
From: Tejun Heo <hidden>
Date: 2021-07-02 00:32:12
Also in:
lkml
From: Tejun Heo <hidden>
Date: 2021-07-02 00:32:12
Also in:
lkml
Hello, On Thu, Jul 01, 2021 at 05:25:59PM -0700, Linus Torvalds wrote:
On Thu, Jul 1, 2021 at 1:55 PM Tejun Heo [off-list ref] wrote:quoted
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-5.14I've pulled it, but let me vent about this history a bit. Look at commit c2a11971549b ("Merge branch 'for-5.13-fixes' into for-5.14"). Now tell me how that commit explains why it exists. Merge commits need commit messages too. In particular, they need commit messages that *explain* why they exist in the first place, not just a one-liner that says what it does (and does so badly at that).
for-5.13-fixes had comment updates across the file and I pulled them into for-5.14 to avoid trivial context conflicts down the line. Yeah, I should have commented on the rationale. Will add explanations from now on. Thanks. -- tejun