Re: ##freemail## Re: [PATCH] cgroup: disable controllers at parse time
From: NOMURA JUNICHI (野村 淳一) <hidden>
Date: 2021-05-18 23:28:26
Also in:
linux-mm, lkml
From: NOMURA JUNICHI (野村 淳一) <hidden>
Date: 2021-05-18 23:28:26
Also in:
linux-mm, lkml
On 2021/05/19 4:54, Yang Shi wrote:
On Tue, May 18, 2021 at 11:13 AM Shakeel Butt [off-list ref] wrote:quoted
On Wed, May 12, 2021 at 1:19 PM Shakeel Butt [off-list ref] wrote:quoted
This patch effectively reverts the commit a3e72739b7a7 ("cgroup: fix too early usage of static_branch_disable()"). The commit 6041186a3258 ("init: initialize jump labels before command line option parsing") has moved the jump_label_init() before parse_args() which has made the commit a3e72739b7a7 unnecessary. On the other hand there are consequences of disabling the controllers later as there are subsystems doing the controller checks for different decisions. One such incident is reported [1] regarding the memory controller and its impact on memory reclaim code. [1] https://lore.kernel.org/linux-mm/921e53f3-4b13-aab8-4a9e-e83ff15371e4-YMj9X0ASwKA@public.gmane.org Signed-off-by: Shakeel Butt <redacted> Reported-by: NOMURA JUNICHI(野村 淳一) <redacted>Nomura, I think you have already tested this patch, so, can you please add your tested-by tag?
Sure, I have confirmed the problem still occurs with v5.13-rc2 and it disappeared with your patch. So, Tested-by: Jun'ichi Nomura <redacted> -- Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.